Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LightningPose data to pooch dataset registry #87

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

niksirbi
Copy link
Member

I've updated the test datasets on GIN, specifically:

  • I've added two sample output .csv files from LightningPoses (prefixed with 'LP')
  • I've reduced the 'DLC_two-mice.predictions.csv` file in size, specifically I've extracted the first 10 minutes from it (previously this file was > 110 MB)

The poses_files_metadata.yaml and poses_registry.txt files have been updated accordingly and now contain the updated sha256 hashes.

This PR adds the new files and hashes to the dataset registry in datasets.py.

This is a pre-requisite for un-blocking #74. After this one gets merged, you can get started on that issue @DhruvSkyy

@b-peri tagging you as a reviewer so you're aware of these changes. After we merge this, you'll probably have to rebase your branch on this one, before you continue with #86

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f2338c) 98.34% compared to head (d3e4e17) 98.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files           8        8           
  Lines         362      362           
=======================================
  Hits          356      356           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niksirbi niksirbi marked this pull request as ready for review November 20, 2023 17:29
@niksirbi niksirbi requested a review from b-peri November 20, 2023 17:30
@niksirbi niksirbi merged commit 7e12f08 into main Nov 22, 2023
24 checks passed
@niksirbi niksirbi deleted the add-lp-test-data branch November 22, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants