-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docs with community section #72
Conversation
updated homepage to have less stuff fixed broken link to contributing guide
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 8 8
Lines 308 308
=======================================
Hits 302 302
Misses 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Co-authored-by: Adam Tyson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀
Co-authored-by: Chang Huan Lo <[email protected]>
This reverts commit 20bed77.
65cf76e
to
7a32c8f
Compare
This error in building the docs took me forever to track down, but I now know its source. Because our documentation includes examples built with Sphinx-Gallery, However, Normally, this wouldn't be a problem for us, since we officially support Python versions 3.9 - 3.11. That said, the reusable workflow we use for building the Sphinx docs includes: - name: Setup Python
uses: actions/setup-python@v4
with:
python-version: '3.x'
We could solve this in a number of ways:
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I solved the issue by updating the GitHub action and running it with Python 3.11. Thanks @alessandrofelder for approving the action update. Merging now. |
The Community section
I updated the movement docs to add a new "Community" section.
It could also be called "About", but I prefer the "Community" term (borrowed from napari docs).
This section includes:
Many thanks to @adamltyson, @lochhh and @sfmig for helping me draft the mission, scope, design principles and roadmap!
Accompanying changes
The docs landing page and the repo README have also been updated to reflect the new structure of the docs. There is an "Overview" section in both, which contains the text @adamltyson wrote for the neuroinformatics main website. There is some regrettable repetition between these two documents (violating DRY), but including content from one of them to the other creates some nasty formatting issues (due to syntax differences between GitHub and Sphinx-Myst markdown). I think some repetition is fine for now, unless we want to write a GitHub action for building the README file automatically. Some links in the README will not work because they lead to the new website pages (which have not been deployed yet), but this should be fixed after merging and releasing.
I also was tempted to include some small docs fixes, e.g. changing the copyright holder to UCL, and making the URL for some pages more sensible.
What is missing from the Community section
How to review this PR
The best way is to build the docs website locally, following these instructions.