-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure "Getting Started" page to a "User Guide" #353
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 14 14
Lines 912 912
=======================================
Hits 910 910
Misses 2 2 ☔ View full report in Codecov by Sentry. |
454fbdf
to
96ccbc6
Compare
Following the feedback I received during out 2024-11-29 meeting, I've made the following modifications to this PR:
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @niksirbi, all LGTM 🚀 ! Except we may have to recreate the PR as it looks like the PR is stuck in "Processing updates" after I accidentally pushed a commit (which has now been removed) to the ns-user-guide
branch while testing your changes. I tried making an empty commit to get the PR unstuck, and this worked, but then when I once again try to remove this commit from the branch, we're back to being stuck 😅
That's super weird, I've never seen this bug before. Anyhow I've opened #356, so I will close this one as superseded by that one. |
Description
What is this PR
Why is this PR needed?
On the website we currently use the "Getting Started" section as a catch-all term for "any content that's not an example and not community-related". Some things in there would really fit well under "Getting Started" - for example the installation - but others include deep dives that are more akin to "conceptual guide" (e.g. explaining the data structure).
I think "Getting started" does not represent this collection well. Moreover, I plan on writing an actual "Quickstart" page that will walk through a basic
movement
workflow, see #284, and the two terms may be confusing.What does this PR do?
This is how our homepage will look with this change:
I configured some redirects such that old links will still resolve correctly despite the renaming. I tested those locally, and by inspecting the contents of
build/html
and it all seems to work out nicely.With #284, a fourth card will be added to the above three, probably named "Quickstart" or "Walkthrough", and it will probably be the first card shown.
This is how the "User guide" page will look like with my proposed change:
The idea is that cards will proliferate as we add more guides. Feel free to push back on this aesthetic choice, I don't feel very strongly about it.
References
This PR sets the stage for #283 and #284.
How has this PR been tested?
Local documentation build.
Is this a breaking change?
No, because of the redirects, old links should work.
Checklist: