Removed "analysis" level from namespace #333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Closes #320.
The "analysis" folder was unnecessary, because it only contains the
kinematics.py
module, and it made our import statements unnecessarily long and complicated.What does this PR do?
I removed the
analysis
folder, and movedkinematics.py
to be a "top-level" module - i.e. instead ofmovement.analysis.kinematics
we havemovement.kinematics
.I then searched and replaced
.analysis.kinematics
with.kinematics
, throughout the repo.References
Related to #327 and #328, but those will be further discussed and tackled separately.
How has this PR been tested?
Existing tests still pass, and docs still build successfully.
Is this a breaking change?
Yes.
Does this PR require an update to the documentation?
Automatically done.
Checklist: