Handle multiprocessing for named loggers. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeZiminski
changed the title
No idea TBH. |
|
@JoeZiminski multiprocessing logging is only used in a few cases (and isn't supported on Windows). I'm happy for this to be merged as is. |
adamltyson
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised in #30 multiprocess logging was not considered. It seems that multiprocess-logging is only setup to work on the root logger. Therefore now if a named logger is requested with multiprocess logging an error is raised.
If multiprocessing is not raised, the startup logs are logged to the previously created logging (rather than root).
This adds a test to check the error is raised. I don't think any documentation is required.
@adamltyson I am not very familiar with multiprocess logging. Would it be hard to write a test for this?