Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate VIA and COCO files for untracked data #20

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Dec 11, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

  • Adds validators for VIA JSON files and COCO JSON files for untracked data
  • Adds test for validators
  • Adds movement as a dependency

TODO:

  • Should the validation associated with ValidVIAUntrackedJSON include the JSON file validation and the general file validation? ---> Use inheritance
    • add tests to check that the children actually run the parent's validations
    • I want the children to run additional validations on the attributes. Is this a good idea? See this SO post.
    • I used a solution suggested in this issue
  • For file specific validations, add a check that verifies the schema defines types for the required keys.
    • otherwise if the schema has all keys that are not present in the input file, it will still pass the validation

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the
documentation has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@sfmig sfmig mentioned this pull request Dec 11, 2024
4 tasks
@sfmig sfmig changed the title Read manual labels from VIA or COCO as dataframe Validate VIA and COCO files for untracked data Dec 16, 2024
@sfmig sfmig force-pushed the smg/read-via-annotations branch 2 times, most recently from 5dcbf0d to 17711ff Compare December 16, 2024 18:43
Copy link

codecov bot commented Dec 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@sfmig sfmig force-pushed the smg/read-via-annotations branch from db737ba to 1e1c9cc Compare December 16, 2024 19:05
@sfmig sfmig force-pushed the smg/read-via-annotations branch from ca95ccd to 3af9b4e Compare December 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant