-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin sphinx 7.2 #398
Unpin sphinx 7.2 #398
Conversation
I kinda see why they introduced the green borders. Previously, it was not super clear to see where the content of a tab/dropdown ended and the "normal" content began. There was a faint horizontal line in between, but at a glance it was not easy to see what belongs to the tab and what not. So I'd be in favour of keeping them despite the visual "clutter" they add, but I don't feel too strongly about this. |
The public datashuttle.neuroinformatics.dev already has the green borders btw and imo it looks ok. I think this is due to a Pydata Sphinx Theme update, not related to the pinned Sphinx version per se. |
@@ -11,7 +11,7 @@ requests | |||
rich | |||
setuptools_scm | |||
simplejson | |||
sphinx<7.2 | |||
sphinx | |||
sphinx-argparse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but do we still need the sphinx-argparse
plugin since we dropped the CLI docs?
The reason is for accessibility. |
Good to know they are taking such a considered and systematic approach to design! I'm glad we have hopped on the |
Nice! Thanks both lets keep them good spot @lochhh. Oh yes indeed |
This PR unpins sphinx, closes #397 that describes the issue.
Tested locally and it builds OK, docs look good. No tests or further documentation required. However, in the new style, the dropdown menus all have a thick green border around them. I will probably turn this off unless @neuroinformatics-unit/neuroinformatics-all particularly likes them (for me it makes the pages look too busy):