Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Python 3.8 and add 3.12 #387

Merged
merged 2 commits into from
May 3, 2024
Merged

Deprecate Python 3.8 and add 3.12 #387

merged 2 commits into from
May 3, 2024

Conversation

JoeZiminski
Copy link
Member

@JoeZiminski JoeZiminski commented May 2, 2024 •
edited
Loading

This PR:

  1. Deprecates python 3.8 (removes from pyproject.toml and test coverage)
  2. Adds python 3.12
  3. Changes the tagline in the pyproject.toml
  4. Changes the development status in pyproject.toml from pre-alpha to beta.

No documentation or tests are required.

@JoeZiminski JoeZiminski changed the title Deprecate python3.8 add3.12 Deprecate Python 3.8 and add 3.12 May 2, 2024
@JoeZiminski JoeZiminski mentioned this pull request May 2, 2024
Merged
@JoeZiminski JoeZiminski requested a review from niksirbi May 2, 2024 15:47
niksirbi
niksirbi approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeZiminski JoeZiminski merged commit 6bb3062 into main May 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niksirbi niksirbi niksirbi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeZiminski @niksirbi