Create folders return split by datatype #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niksirbi
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Hey @JoeZiminski, I spotted a few issues that slipped through in this one. Luckily they are trivial to fix.
|
Thanks @niksirbi for these catches 😱 a lot of mistakes! These should all be fixed now, I added a test to cover the previously broken behaviour. Cheers! |
niksirbi
approved these changes
Jun 10, 2024
… input and display message.
Co-authored-by: Niko Sirmpilatze <[email protected]>
JoeZiminski
force-pushed
the
create_folders_return_split_by_datatype
branch
from
6f1f1b9 to
3a69bfa
Compare
JoeZiminski
force-pushed
the
create_folders_return_split_by_datatype
branch
from
362b0b1 to
2b927f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the output of
create_foldersby datatype. Now aDictis returned with datatypes as keys and a list of created paths as values. If no datatype is created the dict keys aresuborses.Test and docs are updated. closes #374.