Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename transfer methods. #360

Merged
merged 7 commits into from
Apr 10, 2024
Merged

Rename transfer methods. #360

merged 7 commits into from
Apr 10, 2024

Conversation

JoeZiminski
Copy link
Member

@JoeZiminski JoeZiminski commented Apr 9, 2024

Renames:

upload_all -> upload_rawdata & upload_derivatives
download_all -> download_rawdata & download_derivatives
upload -> upload_custom
download -> download_custom

and changed approrpiate section in documentation. Tests are updated, and tested manually in API and TUI.

@JoeZiminski JoeZiminski changed the title Rename transfer methods Rename transfer methods. Apr 9, 2024
@JoeZiminski JoeZiminski linked an issue Apr 9, 2024 that may be closed by this pull request
@JoeZiminski JoeZiminski requested a review from niksirbi April 9, 2024 14:28
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

datashuttle/tui/interface.py Outdated Show resolved Hide resolved
docs/source/pages/how_tos/transfer-data.md Outdated Show resolved Hide resolved
@JoeZiminski JoeZiminski force-pushed the rename_transfer_methods branch from 110607a to 1496b20 Compare April 10, 2024 17:10
@JoeZiminski JoeZiminski merged commit 971d15d into main Apr 10, 2024
21 checks passed
@JoeZiminski JoeZiminski deleted the rename_transfer_methods branch April 10, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming the transfer functions
2 participants