Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for multi-version sphinx docs #61

Merged
merged 18 commits into from
Nov 29, 2024
Merged

Conversation

niksirbi
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the
documentation has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@niksirbi niksirbi changed the title Add workflow for multi-versions sphinx docs Add workflow for multi-version sphinx docs Nov 22, 2024
@niksirbi niksirbi force-pushed the multi-version-docs-workflow branch from 8b498af to f43b2b1 Compare November 22, 2024 16:31
@niksirbi niksirbi marked this pull request as ready for review November 29, 2024 17:04
@IgorTatarnikov IgorTatarnikov requested a review from sfmig November 29, 2024 17:05
@niksirbi niksirbi removed the request for review from IgorTatarnikov November 29, 2024 17:06
Copy link

@sfmig sfmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done surviving this!

fi
# Make the push quiet just in case there is anything that could leak
# sensitive information.
echo -e "\nPushing changes to gh-pages."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this is probably better dealt with a token

@sfmig sfmig merged commit 452fe10 into main Nov 29, 2024
3 checks passed
@sfmig sfmig deleted the multi-version-docs-workflow branch November 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants