-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for vscode with slurm #67
Conversation
Working on failing actions |
14ecd04
to
936f829
Compare
936f829
to
1aa5d5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. TBH I haven't tested it because I don't use VSCode. I thought @niksirbi might be kind enough to give it a spin 🚗.
I'm looking forward to reviewing it as soon as I find the time. |
Co-authored-by: Adam Tyson <[email protected]>
027fd62
to
68c844a
Compare
68c844a
to
49ad855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find @lauraporta!
As far as I can tell this works as intended, and is the most hussle-free method I've tried so far and the only pre-requisite is a github account.
I could also login with my VScode account, sync all my extensions, settings etc, all working seamlessly!
I also ran some jupyter notebook within VSCode, and everything worked perfectly well, including plots.
SLURM killed my jobs at the specified time limit, so we shouldn't be eating more resources than allocated.
All in all, 10/10!
It may be worth announcing this on the institute's slack as the "recommended" way to use VSCode on the cluster (after consulting with the scientific computing team perhaps).
And just two small comments on the guide:
|
Strange. I wonder if the resources given to the compute node "by default" are not sufficient for whatever VSCode does when tunneling. What happens if you try: srun -p gpu -n 4 --mem 8G --gres=gpu:1 --pty bash -i Just a random guess, not sure if this is indeed your problem. |
If you want to use your own VScode app rather than the webapp, you can do this (from this blog post):
Presumably this allows you to have all your vscode extensions, settings etc, even if you don't have a VSCode account. |
I can confirm the steps above now also work for me with the two |
Definitely yes.
Interesting. Reading the highlighted section of the guide you point to, I think it means that we are not running source code on our local client (in this case the browser) but instead on the compute node in which code tunnel is run.
Going to test this as well! |
✨ A M A Z I N G ✨ I just didn't have the Tunnel extension installed. As the tunnel is maintained by the same kind of slurm job, it should be killed in the same way. Going to include this solution. Anyway is anyone getting the notification "Unable to watch for changes"? |
Aaah I see! Sorry I wasn't sure who the client was 😅 |
A somewhat equivalent approach using
This works for me at the moment. The problem of this approach is that the SLURM limits assigned to the user in the The benefit of the
|
Yes
We've tested for time limit and manually killing the job. Unsure about resources in the same node while the job is running |
Phew, a bit of confidence in my own understanding of this restored. |
Co-authored-by: Niko Sirmpilatze <[email protected]>
Co-authored-by: Niko Sirmpilatze <[email protected]>
Thanks for updating it @lauraporta. I'm happy with the content, just added some comments on wording and rendering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was a great find, thanks @lauraporta 🚀
Just small things such as some vscode ->VSCode and slurm -> SLURM. Nothing major, feel free to take or leave as you please!
Co-authored-by: sfmig <[email protected]>
Co-authored-by: sfmig <[email protected]>
Co-authored-by: sfmig <[email protected]>
Co-authored-by: sfmig <[email protected]>
Co-authored-by: sfmig <[email protected]>
Co-authored-by: sfmig <[email protected]>
Co-authored-by: sfmig <[email protected]>
Co-authored-by: sfmig <[email protected]>
Co-authored-by: sfmig <[email protected]>
Description
What is this PR
Why is this PR needed?
We've been exploring optimal ways to use VSCode within a SLURM job to ensure appropriate use of assigned resources. After testing a solution suggested in our internal Slack,
code tunnel
, I found it to be effective. This approach is straightforward, user-friendly, and fully SLURM-managed, allowing resources to be properly allocated and controlled within the job environment.Happy to hear your thoughts about it!
What does this PR do?
Adds a markdown file with the guide.
References
#62 issue discussion
How has this PR been tested?
Checklist: