-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to use the SLEAP HPC module with SLURM #40
Conversation
592cf89
to
f92a91f
Compare
f92a91f
to
2623cf3
Compare
262f1c6
to
fa423a2
Compare
Just my neglect. I started working on this very long ago, when not all of us were super familiar with sphinx local builds and I intended to make life easier for reviewers. But now that we are all such Sphinx pros, there is no need to do that, and I should stop doing it. I had just forgotten that it was configured "the old way" on this branch, and I only realised after the build went public 😨 |
@niksirbi the bigger problem is the continued insane GitHub bug that ended up with you updating my comment!?! |
exactly, it almost happened again, but I realised it in time now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. I only skimmed the SLEAP section (as suggested), but everything looks good. Some tiny suggestions.
@niksirbi I also don't get why we can edit each others comments anyway. I can use the dropdown to edit your messages using the GitHub UI. Is it because of the permissions we have for the repo? |
Maybe because we are all admins. Should I set |
Applied Adam's suggestions from code review Co-authored-by: Adam Tyson <[email protected]>
yeah that sounds good. Especially as this is the new, larger set of contributors. |
Done, do you still have permission to edit my posts (you shouldn't now)? |
I do, but I'm admin of the whole org, so I guess that's expected (but still weird). |
|
Crazy. Anyway, yell at me if I accidentality edit any comments and I'll try to be more careful. I really don't think we should be editing what other people say! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This PR adds two how-to guides:
Other than that, there are some small bits and pieces, like:
sphinx-copybutton
to enable copy-pasting from our code-blocksI would suggest @lochhh looks at the SLEAP part, because she has seen an earlier version of it already, and @adamltyson reviews the SLURM bit, as it might be useful/relevant for the upcoming HPC course.
The best way to review this is to directly look at the rendered website build. I've temporarily overridden the workflow rules to allow publication from this PR, which means that I have to: