Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v3 #1484

Draft
wants to merge 48 commits into
base: develop
Choose a base branch
from
Draft

Release v3 #1484

wants to merge 48 commits into from

Conversation

sreichel
Copy link
Collaborator

@sreichel sreichel commented Nov 13, 2024 •
edited
Loading

See ... #1326

  • added strict types
  • phpstan level 7
  • per-2 coding
  • use all rector rules
  • added checks to workflow
  • added Carbon for date funtions (not finished)

Magerun pull-request check-list:

  • Pull request against develop branch (if not, just close and create a new one against it)
  • README.md reflects changes (if any)

@sreichel sreichel changed the title Phpstan: push to level 3 Phpstan: push to level 4 Nov 13, 2024
@sreichel sreichel changed the title Phpstan: push to level 4 Phpstan: push to level 5 Nov 13, 2024
@sreichel sreichel force-pushed the phpstan branch 16 times, most recently from 5ab215e to 58887b7 Compare December 12, 2024 09:17
@sreichel sreichel force-pushed the phpstan branch 2 times, most recently from a4b716b to 3d38aad Compare December 16, 2024 09:21
@sreichel sreichel changed the title Phpstan: push to level 5 Release v3 Dec 18, 2024
@sreichel sreichel marked this pull request as ready for review December 18, 2024 10:31
@sreichel
Copy link
Collaborator Author

@cmuench can you plese check phar-build, or should i revert phing to 2.7?

@cmuench
Copy link
Member

cmuench commented Dec 18, 2024

@cmuench can you plese check phar-build, or should i revert phing to 2.7?

I can try to backport the phar build process of n98-magerun2 where phing was replaced by box to build the phar file.

@cmuench cmuench mentioned this pull request Dec 18, 2024
Merged
1 task
@cmuench
Copy link
Member

cmuench commented Dec 18, 2024

@sreichel I have backported the phar generation process but we need a rebase now.

@sreichel
Merge branch 'develop' into phpstan
d07e28e 
# Conflicts:
#	composer.json
#	composer.lock
#	src/N98/Magento/Application.php
#	src/N98/Magento/Command/Config/GetCommand.php
#	src/N98/Magento/Command/Database/AbstractShowCommand.php
#	src/N98/Magento/Command/Developer/EmailTemplate/UsageCommand.php
#	src/N98/Magento/Command/Developer/Theme/InfoCommand.php
#	src/N98/Magento/Command/Script/Repository/ListCommand.php
@sreichel
Copy link
Collaborator Author

@cmuench nice.

I did not re-test every command manually, but everything i have tested works.

  • PHPstan 8/9 is mostly DOCblocks
  • using constants for commands and other cosmetic changes
  • use symfony filesystem, ...

... coming later.

@sreichel sreichel mentioned this pull request Dec 19, 2024
Merged
@sreichel sreichel marked this pull request as draft December 25, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreichel @cmuench