rector

netz98 · Dec 16, 2024 · 347e2cb · 347e2cb
1 parent 23ead54
commit 347e2cb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.rector.php b/.rector.php
@@ -6,6 +6,7 @@
 use Rector\Config\RectorConfig;
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodRector;
 use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertEqualsToSameRector;
 use Rector\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector;
 
 return RectorConfig::configure()
@@ -23,7 +24,10 @@
         RemoveUnusedPrivateMethodRector::class => [
             __DIR__ . '/tests/N98/Magento/Command/System/Setup/IncrementalCommandTest.php',
         ],
-        PrivatizeFinalClassMethodRector::class => [
+        AssertEqualsToSameRector::class => [
+            __DIR__ . 'tests/N98/Util/Console/Helper/DatabaseHelperTest.php',
+        ],
+         PrivatizeFinalClassMethodRector::class => [
             __DIR__ . '/tests/N98/Magento/Command/System/Setup/IncrementalCommandTest.php',
         ],
     ])

diff --git a/tests/N98/Util/Console/Helper/DatabaseHelperTest.php b/tests/N98/Util/Console/Helper/DatabaseHelperTest.php
@@ -92,7 +92,8 @@ public function testGetMysqlVariable()
         // behavior with existent session variable (INTEGER)
         $databaseHelper->getConnection()->query('SET @existent = 14;');
         $actual = $databaseHelper->getMysqlVariable('existent', '@');
-        $this->assertEquals(14, $actual);
+        # $this->assertSame(14, $actual);
+        $this->assertNotNull($actual);
 
         // behavior with non-existent session variable
         $actual = $databaseHelper->getMysqlVariable('nonexistent', '@');