Use Generic Name for SimplePool Connection Threads (1.6.x) #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miklish
changed the title
miklish
requested review from
jaydeepparekh1311,
AkashWorkGit and
zabooma
and removed request for
jaydeepparekh1311 and
AkashWorkGit
AkashWorkGit
approved these changes
Apr 9, 2024
|
@miklish Are we ready to merge this PR? Thanks. |
|
@stevehu yes this can be merged thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2089
Currently SimplePool connection threads are named either "Callback-HTTP11" or "Callback-HTTP2" depending on the type of connection.
However, since this threadpool is only named ONCE, then the name of all SimplePool connection threads is based on the first type of connection that SimplePool was asked to make (HTTP/1.1 or HTTP/2).
This can cause misleading messages in the logs, since if subsequent calls to the pool create different connection types, then the thread name and connection type won't match.
E.g.: If an HTTP/1.1 connection is the first connection the pool makes, then any subsequent HTTP/2 connection threads will have the name "Callback-HTTP11".