Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Generic Name for SimplePool Connection Threads (1.6.x) #2089

Open
miklish opened this issue Jan 26, 2024 · 0 comments
Open

Use Generic Name for SimplePool Connection Threads (1.6.x) #2089

miklish opened this issue Jan 26, 2024 · 0 comments

Comments

@miklish
Copy link
Collaborator

miklish commented Jan 26, 2024

PR: #2090

Currently SimplePool connection threads are named either "Callback-HTTP11" or "Callback-HTTP11" depending on the type of connection.

However, since this threadpool is only named ONCE, then the name of all SimplePool connection threads is based on the first type of connection that SimplePool was asked to make (HTTP/1.1 or HTTP/2).

This can cause misleading messages in the logs, since if subsequent calls to the pool create different connection types, then the thread name and connection type won't match.

E.g.: If an HTTP/1.1 connection is the first connection the pool makes, then any subsequent HTTP/2 connection threads will have the name "Callback-HTTP11".

@miklish miklish changed the title User Generic Name for SimplePool Connection-creation Threads (1.6.x) Use Generic Name for SimplePool Connection-creation Threads (1.6.x) Jan 26, 2024
@miklish miklish changed the title Use Generic Name for SimplePool Connection-creation Threads (1.6.x) Use Generic Name for SimplePool Connection Threads (1.6.x) Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant