Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting interface name and wireguard port #1467

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

mlsmaycon
Copy link
Collaborator

Describe your changes

This PR adds support for setting the wireguard interface name and port with the netbird up command

e.g.:
Setting custom interface name:

netbird down
netbird up --interface-name utun101

Setting custom Wireguard port:

netbird down
netbird up  --wireguard-port 51822

Setting custom interface name and port with environment variables:

netbird down
export NB_INTERFACE_NAME=utun103 
export NB_WIREGUARD_PORT=52000
netbird up

Setting custom interface name and port in foreground:

sudo netbird up -F --interface-name utun101  --wireguard-port 51822

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

This PR adds support for setting the
wireguard interface name and port
with the netbird up command
lixmal
lixmal previously approved these changes Jan 15, 2024
client/cmd/root.go Outdated Show resolved Hide resolved
check interface name on macOS
@mlsmaycon mlsmaycon merged commit e9c967b into main Jan 15, 2024
15 checks passed
@mlsmaycon mlsmaycon deleted the change-iface-name-port branch January 15, 2024 14:53
@nazarewk
Copy link
Contributor

nazarewk commented Jan 31, 2024

FYI: works wonderfully keeping the configuration in sync with envvars on each start https://github.com/nazarewk-iac/nix-configs/blob/c81fae581c636786775a2e095d04913fe1c37ddc/modules/networking/netbird/default.nix#L73-L74

Foosec pushed a commit to Foosec/netbird that referenced this pull request May 8, 2024
…1467)

This PR adds support for setting the
wireguard interface name and port
with the netbird up command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants