allow specifying --wg-iface and --wg-port

[nazarewk]

Describe your changes

I am working on setting up multiple instances of Netbird on same machine, I need a way to tell the deamon to input different interfaces/ports to those without modifying files by hand.

I got it to work at nazarewk-iac/nix-configs@aeefbf5c

Issue ticket number and link

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

[nazarewk]

I guess adding entries to interfaces blacklist would be handy too

[mlsmaycon]

hello @nazarewk, thanks for the contribution.

The Pr is still with a Draft status. I have a few comments to add and some requests as well, but I wonder if you want to add more to it.

[nazarewk]

hello @nazarewk, thanks for the contribution.

The Pr is still with a Draft status. I have a few comments to add and some requests as well, but I wonder if you want to add more to it.

I have what I personally need in the PR, but I'm up for comments.

[mlsmaycon]

thanks @nazarewk. I left some comments regarding the input; we are moving things a bit to be configured through the up command to prevent reinstallation of the daemon.

[nazarewk]

what is the difference between netbird up and netbird service run/start/stop? After moving flags to up I'm not getting those reflected in my service file.

[mlsmaycon]

what is the difference between netbird up and netbird service run/start/stop? After moving flags to up I'm not getting those reflected in my service file.

The service start and stop only controls the OS system start and stop of a service. The run starts netbird as a daemon process, which listens for commands and updates the process execution.

I saw that you updated the flags to be added with the service run, but the problem there is that to update a configuration you need to reinstall the client for most installations, this is due because the netbird service install generates a static service configuration and not updating it will make every restart restore any update made with up

[mlsmaycon]

Suggested change

	if !slices.Contains(config.IFaceBlackList, config.WgIface) {
	var newBlacklist []string
	replaced := false
	for _, ifc := range config.IFaceBlackList {
	if ifc == oldIface {
	ifc = config.WgIface
	replaced = true
	}
	newBlacklist = append(newBlacklist, ifc)
	}
	if !replaced {
	newBlacklist = append(newBlacklist, config.WgIface)
	}
	log.Infof("prepending Wireguard Interface Name to interface blacklist %#v, updated to %v (old value %v)", config.WgIface, newBlacklist, config.IFaceBlackList)
	config.IFaceBlackList = newBlacklist
	refresh = true
	}
	if oldIface != config.WgIface {
	for i, ifc := range config.IFaceBlackList {
	if ifc == oldIface {
	ifc = config.WgIface
	config.IFaceBlackList[i] = config.WgIface
	log.Infof("replaced Wireguard Interface Name in the interface blacklist. old name %s, new name", oldIface, config.WgIface)
	refresh = true
	break
	}
	}
	}

[mlsmaycon]

Suggested change

	if input.WgPort != 0 && input.WgPort != config.WgPort {
	log.Infof("new Wireguard Port provided, updated to %#v (old value %#v)", input.WgPort, config.WgPort)
	config.WgPort = input.WgPort
	refresh = true
	}

[mlsmaycon]

Suggested change

	if config.WgPort == 0 && input.WgPort == 0 {
	log.Infof("using default Wireguard Port: %#v ", iface.DefaultWgPort)
	config.WgPort = iface.DefaultWgPort
	refresh = true
	}
	if input.WgPort != 0 && input.WgPort != config.WgPort {
	log.Infof("new Wireguard Port provided, updated to %d (old value %d)", input.WgPort, config.WgPort)
	config.WgPort = input.WgPort
	refresh = true
	}
	// previous version config upgrade check because WgPort didn't exist
	if config.WgPort == 0 {
	log.Infof("using default Wireguard Port: %d", iface.DefaultWgPort)
	config.WgPort = iface.DefaultWgPort
	refresh = true
	}

[mlsmaycon]

@nazarewk, my apologies, I forgot about the protocol update required to pass the new flags from the client to the daemon.

You need to update the protocol file here /client/proto/daemon.proto#L31 and then you can run the generate.sh

Once that is done, you need to retrieve them in the https://github.com/netbirdio/netbird/blob/main/client/server/server.go#L158 and pass to the configuration calls

With that updating the port will look like this:

netbird down
netbird up --wg-port 5000

[mlsmaycon]

@nazarewk let us know if the requests were too much. I would be happy to join the effort and help you in your branch

[nazarewk]

@mlsmaycon I can't continue this right now (maybe next week) and I'm not planning to become Netbird architecture expert so feel free to help and fix the things you mentioned :)

[mlsmaycon]

@nazarewk, thanks for the contribution. We have decided to move forward with the flag support in the following PR: #1467

For now, I will close this one, and we can discuss further improvements on a separate ticket/issue.