Make test folder for src structure and refactored verify_version tests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgozsoy-neo4j
approved these changes
May 1, 2024
| fulltext_index_name = "my-fulltext-index" | ||
| query_text = "may thy knife chip and shatter" | ||
| top_k = 5 | ||
| retrieval_query = """ |
There was a problem hiding this comment.
(Not important) It could be out of scope: Should we test cases when input retrieval query or index names are wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before working on E2E tests, I wanted to refactor the test folder to make writing the E2E tests more easily
This PR:
src/folder structure._verify_version()of base retriever.Retrievercall_verify_version()