Add the el5042 driver #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o prestonr-add-el5042
| { | ||
| MSG_DEBUG("Parsing clock frequency string: %s", clock_frequency_string.c_str()); | ||
|
|
||
| if (clock_frequency_string.compare("10MHz") == 0) { |
There was a problem hiding this comment.
Have you been able to test the different read rates using this interface on hardware?
|
Looks good to me, other than being sure that the different frequency range settings on el5042 get tested, given you said the rest has already been run on ERNEST |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameters to the PO2SO to allow full customization of the EL5042 BiSS-C interface at startup.
This driver allows one to communicate via BiSS-C or SSI to an encoder.