Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP Notices: Include updated statistics core schema #138

Closed
wants to merge 1 commit into from
Closed

EP Notices: Include updated statistics core schema #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions gcn/notices/einstein_probe/wxt/alert.schema.example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
"dec": 40,
"ra_dec_error": 0.02,
"image_energy_range": [0.5, 4.0],
"net_rate": 1.0,
"image_snr": 1.0
"image_snr": 1.0,
"net_count_rate": 1.0,
"backgound_count_rate": 0.2,
"rate_duration": 10,
"rate_energy_range": [0.5, 4.0]
Comment on lines +11 to +13
Copy link
Contributor

@modot modot Apr 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We suggest avoid to including these three lines (11-13) as they are not relavent to WXT.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@modot, the net count rate would be for what duration? Energy range was mentioned in description earlier, it's fine if it's same as image energy range.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The count rate serves as a reference for the flux of the source, while estimating the duration for WXT is challenging. The energy range is the same with that of the image.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"backgound_count_rate": 0.2,
"rate_duration": 10,
"rate_energy_range": [0.5, 4.0]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you. @jracusin shall we add additional comment for this count rate, will help users or merge as it is?

Copy link
Member Author

@Vidushi-GitHub Vidushi-GitHub Apr 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@modot For users, would you like to add a comment for net_count_rate using AdditionalInfo.schema from the core? This will prevent confusion with traditional calculation for GRB type events.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vidushi-GitHub Sure, I'll create a new PR to add a comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@modot For users, would you like to add a comment for net_count_rate using AdditionalInfo.schema from the core? This will prevent confusion with traditional calculation for GRB type events.

@Vidushi-GitHub Would you please review the PR on #139 ?

}
10 changes: 1 addition & 9 deletions gcn/notices/einstein_probe/wxt/alert.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,5 @@
{ "$ref": "../../core/Localization.schema.json" },
{ "$ref": "../../core/Reporter.schema.json" },
{ "$ref": "../../core/Statistics.schema.json" }
],
"properties": {
"$schema": true,
"net_rate": {
"type": "number",
"description": "Net count rate [cnt/sec] of the transient in WXT band (0.5-4.0 keV)."
}
},
"unevaluatedProperties": false
]
}
Loading