EP Notices: Include updated statistics core schema #138
Conversation
| "backgound_count_rate": 0.2, | ||
| "rate_duration": 10, | ||
| "rate_energy_range": [0.5, 4.0] |
There was a problem hiding this comment.
We suggest avoid to including these three lines (11-13) as they are not relavent to WXT.
There was a problem hiding this comment.
@modot, the net count rate would be for what duration? Energy range was mentioned in description earlier, it's fine if it's same as image energy range.
There was a problem hiding this comment.
The count rate serves as a reference for the flux of the source, while estimating the duration for WXT is challenging. The energy range is the same with that of the image.
There was a problem hiding this comment.
| "backgound_count_rate": 0.2, | |
| "rate_duration": 10, | |
| "rate_energy_range": [0.5, 4.0] |
There was a problem hiding this comment.
Ok, thank you. @jracusin shall we add additional comment for this count rate, will help users or merge as it is?
There was a problem hiding this comment.
@modot For users, would you like to add a comment for net_count_rate using AdditionalInfo.schema from the core? This will prevent confusion with traditional calculation for GRB type events.
There was a problem hiding this comment.
@Vidushi-GitHub Sure, I'll create a new PR to add a comment.
There was a problem hiding this comment.
@modot For users, would you like to add a comment for net_count_rate using AdditionalInfo.schema from the core? This will prevent confusion with traditional calculation for GRB type events.
@Vidushi-GitHub Would you please review the PR on #139 ?
|
A new PR is opened for it: #139 |
@modot we realized that the count's property in EP Schema is relevant for other missions,
thus, Statistics Core Schema has been updated.
The following fields are also required with the net count rate property:
Please check this PR and add/suggest corrections.