Add TCB->TDB flag for EQUAD created from TNEQUAD #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n from TNEQUAD to EQUAD free of scaling
…onversion from TNEQUAD to EQUAD free of scaling" This reverts commit b88b28e.
…n from TNEQUAD to EQUAD free of scaling
dlakaplan
added
the
awaiting review
|
@abhisrkckl : this is very minor |
|
This looks good to me. Shall I merge this? |
abhisrkckl
reviewed
Nov 11, 2024
CHANGELOG-unreleased.md
Outdated
Comment on lines
13
to
15
| * When TCB->TDB conversion info is missing, will print parameter name | ||
| ### Fixed | ||
| * When EQUAD is created from TNEQ, has proper TCB->TDB conversion info |
There was a problem hiding this comment.
The bullet points are indicated with "-", not "*"
I think you can, although I didn't search exhaustively to see if any other parameters were missing the scaling info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add explicit printing of which parameters cause TCB->TDB conversion to fail