Merge pull request #1857 from dlakaplan/tnequad_tcb

Add TCB->TDB flag for EQUAD created from TNEQUAD
nanograv · Nov 12, 2024 · 6eebdcb · 6eebdcb
2 parents 8c8b126 + e559035
commit 6eebdcb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/CHANGELOG-unreleased.md b/CHANGELOG-unreleased.md
@@ -10,5 +10,7 @@ the released changes.
 ## Unreleased
 ### Changed
 ### Added
+- When TCB->TDB conversion info is missing, will print parameter name
 ### Fixed
+- When EQUAD is created from TNEQ, has proper TCB->TDB conversion info
 ### Removed
diff --git a/src/pint/models/noise_model.py b/src/pint/models/noise_model.py
@@ -122,6 +122,7 @@ def setup(self):
                             index=tneq_par.index,
                             aliases=["T2EQUAD"],
                             description="An error term added in quadrature to the scaled (by EFAC) TOA uncertainty.",
+                            convert_tcb2tdb=False,
                         )
                     )
                 EQUAD_par = getattr(self, EQUAD_name)

diff --git a/src/pint/models/parameter.py b/src/pint/models/parameter.py
@@ -709,7 +709,7 @@ def __init__(
 
         assert (
             not convert_tcb2tdb or tcb2tdb_scale_factor is not None
-        ), "Please specify the tcb2tdb_scale_factor explicitly."
+        ), f"Please specify the tcb2tdb_scale_factor explicitly for {name}."
         self.convert_tcb2tdb = convert_tcb2tdb
         self.tcb2tdb_scale_factor = tcb2tdb_scale_factor
 
@@ -1133,7 +1133,7 @@ def __init__(
 
         assert (
             not convert_tcb2tdb or tcb2tdb_scale_factor is not None
-        ), "Please specify the tcb2tdb_scale_factor explicitly."
+        ), f"Please specify the tcb2tdb_scale_factor explicitly for {name}."
         self.convert_tcb2tdb = convert_tcb2tdb
         self.tcb2tdb_scale_factor = tcb2tdb_scale_factor
 
@@ -1334,7 +1334,7 @@ def __init__(
 
         assert (
             not convert_tcb2tdb or tcb2tdb_scale_factor is not None
-        ), "Please specify the tcb2tdb_scale_factor explicitly."
+        ), f"Please specify the tcb2tdb_scale_factor explicitly for {name}."
         self.convert_tcb2tdb = convert_tcb2tdb
         self.tcb2tdb_scale_factor = tcb2tdb_scale_factor
 
@@ -1554,7 +1554,7 @@ def __init__(
         # a function of the prefix.
         assert (
             not convert_tcb2tdb or tcb2tdb_scale_factor is not None
-        ), "Please specify the tcb2tdb_scale_factor explicitly."
+        ), f"Please specify the tcb2tdb_scale_factor explicitly for {name}."
         tcb2tdb_scale_factor_val = (
             tcb2tdb_scale_factor(self.prefix)
             if hasattr(tcb2tdb_scale_factor, "__call__")