Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum-likelihood fit for ECORR #1673

Merged
merged 63 commits into from
Dec 28, 2023
Merged

Conversation

abhisrkckl
Copy link
Contributor

@abhisrkckl abhisrkckl commented Nov 8, 2023

  • Enables maximum-likelihood fitting for ECORR parameters when time-correlated noise components are absent.
  • Only available in DowhillGLSFitter.
  • Also works in pintk
  • Fitting for time-correlated noise components is too slow at the moment. (May come back to this later).
  • Added an example notebook for noise fitting.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (602cfba) 68.78% compared to head (fd05c72) 68.76%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/pint/residuals.py 55.46% 46 Missing and 7 partials ⚠️
src/pint/models/timing_model.py 63.63% 5 Missing and 3 partials ⚠️
src/pint/utils.py 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1673      +/-   ##
==========================================
- Coverage   68.78%   68.76%   -0.03%     
==========================================
  Files         105      105              
  Lines       24556    24630      +74     
  Branches     4401     4401              
==========================================
+ Hits        16892    16936      +44     
- Misses       6555     6589      +34     
+ Partials     1109     1105       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhisrkckl abhisrkckl linked an issue Dec 6, 2023 that may be closed by this pull request
@abhisrkckl abhisrkckl changed the title WIP: Maximum-likelihood fit for ECORR Maximum-likelihood fit for ECORR Dec 6, 2023
@abhisrkckl
Copy link
Contributor Author

I have given up on implementing the ecorr derivatives for the time being. The fitting works fine without them, albeit slower (but not prohibitively so). I'll come back to this after finishing the paper.

@abhisrkckl
Copy link
Contributor Author

One more simulated example:
image

The corner plot is from ENTERPRISE analysis.
Blue "truth" lines represent the injected values.
Red error bar plots represent the PINT maximum-likelihood estimates.

@abhisrkckl abhisrkckl added the awaiting review This PR needs someone to review it so it can be merged label Dec 6, 2023
@abhisrkckl
Copy link
Contributor Author

@dlakaplan
Copy link
Contributor

The results look reasonable, although I haven't been able to check over the new code line-by-line.

@dlakaplan
Copy link
Contributor

While I didn't look line-by-line, I can merge this if you want. It shouldn't hurt anything existing and more use might exposure any issues (or it might just be a great new feature).

@abhisrkckl
Copy link
Contributor Author

Yes. Please merge this.

@dlakaplan
Copy link
Contributor

I think there is an issue with the ephemeris hosted at NANOGrav (@JPGlaser ). Probably we can ignore this?

@abhisrkckl
Copy link
Contributor Author

Yes. I reran the failed ephemeris_connection tests, but they failed again. I think we can ignore that.

@dlakaplan dlakaplan merged commit 59fc4e5 into nanograv:master Dec 28, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_noisefit.py::test_white_noise_refit often fails
2 participants