-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maximum-likelihood fit for ECORR #1673
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1673 +/- ##
==========================================
- Coverage 68.78% 68.76% -0.03%
==========================================
Files 105 105
Lines 24556 24630 +74
Branches 4401 4401
==========================================
+ Hits 16892 16936 +44
- Misses 6555 6589 +34
+ Partials 1109 1105 -4 ☔ View full report in Codecov by Sentry. |
I have given up on implementing the ecorr derivatives for the time being. The fitting works fine without them, albeit slower (but not prohibitively so). I'll come back to this after finishing the paper. |
The results look reasonable, although I haven't been able to check over the new code line-by-line. |
While I didn't look line-by-line, I can merge this if you want. It shouldn't hurt anything existing and more use might exposure any issues (or it might just be a great new feature). |
Yes. Please merge this. |
I think there is an issue with the ephemeris hosted at NANOGrav (@JPGlaser ). Probably we can ignore this? |
Yes. I reran the failed ephemeris_connection tests, but they failed again. I think we can ignore that. |
DowhillGLSFitter
.