Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_noisefit.py::test_white_noise_refit often fails #1686

Closed
dlakaplan opened this issue Dec 1, 2023 · 2 comments · Fixed by #1673
Closed

test_noisefit.py::test_white_noise_refit often fails #1686

dlakaplan opened this issue Dec 1, 2023 · 2 comments · Fixed by #1673

Comments

@dlakaplan
Copy link
Contributor

Maybe this needs different tolerances?
@dlakaplan
Copy link
Contributor Author

@abhisrkckl : is this from one of your PRs? I can usually rerun the tests and it's OK but it may be better to adjust.

@abhisrkckl
Copy link
Contributor

Yes. It sometimes fails for me too. It may be a good idea to relax the tolerance on this.

@abhisrkckl abhisrkckl linked a pull request Dec 6, 2023 that will close this issue
Maximum-likelihood fit for ECORR #1673
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Maximum-likelihood fit for ECORR abhisrkckl/PINT
2 participants
@dlakaplan @abhisrkckl