Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full name for observatories #1668

Merged
merged 13 commits into from
Nov 3, 2023
Merged

Conversation

dlakaplan
Copy link
Contributor

  • Adds a separate .fullname attribute for observatories.
  • Observatories in observatories.json all have actual names now.

@dlakaplan dlakaplan linked an issue Nov 2, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (01a5ac0) 68.47% compared to head (bd29643) 68.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
- Coverage   68.47%   68.47%   -0.01%     
==========================================
  Files         104      104              
  Lines       24287    24289       +2     
  Branches     4336     4336              
==========================================
+ Hits        16630    16631       +1     
- Misses       6571     6572       +1     
  Partials     1086     1086              
Files Coverage Δ
src/pint/observatory/__init__.py 81.65% <100.00%> (+0.05%) ⬆️
src/pint/observatory/topo_obs.py 82.63% <0.00%> (-0.50%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlakaplan
Copy link
Contributor Author

Identified some broken observatory positions #1669

@dlakaplan
Copy link
Contributor Author

src/pint/data/runtime/observatories.json Outdated Show resolved Hide resolved
src/pint/data/runtime/observatories.json Outdated Show resolved Hide resolved
src/pint/data/runtime/observatories.json Outdated Show resolved Hide resolved
src/pint/data/runtime/observatories.json Outdated Show resolved Hide resolved
src/pint/data/runtime/observatories.json Outdated Show resolved Hide resolved
@abhisrkckl
Copy link
Contributor

I'll merge this if this is ready.

@dlakaplan
Copy link
Contributor Author

I think it's ready

@abhisrkckl abhisrkckl merged commit 6cfd2c5 into nanograv:master Nov 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observatories should have a separate name attribute
3 participants