Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensibly handle unfittable params, No unfittable params in plk #1648

Merged
merged 12 commits into from
Oct 17, 2023

Merge branch 'master' into fittable-params

fb14307
Select commit
Loading
Failed to load commit list.
Merged

Sensibly handle unfittable params, No unfittable params in plk #1648

Merge branch 'master' into fittable-params
fb14307
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 13, 2023 in 0s

68.34% (-0.01%) compared to 9e21a05

View this Pull Request on Codecov

68.34% (-0.01%) compared to 9e21a05

Details

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9e21a05) 68.34% compared to head (fb14307) 68.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   68.34%   68.34%   -0.01%     
==========================================
  Files         104      104              
  Lines       24101    24112      +11     
  Branches     4277     4280       +3     
==========================================
+ Hits        16473    16480       +7     
- Misses       6545     6547       +2     
- Partials     1083     1085       +2     
Files Coverage Δ
src/pint/models/binary_ell1.py 86.18% <100.00%> (+0.18%) ⬆️
src/pint/pintk/plk.py 13.51% <ø> (ø)
src/pint/fitter.py 83.63% <0.00%> (-0.21%) ⬇️
src/pint/models/timing_model.py 83.82% <50.00%> (-0.13%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.