-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensibly handle unfittable params, No unfittable params in plk
#1648
Conversation
The errors here might be due to function parameters which are visible but not intrinsically part of the model. So maybe just a check for parameter type as well. |
A subset of the errors were indeed indirectly related to funcParameters. But they were actually due to a bug in the ELL1k model which I have fixed. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
- Coverage 68.34% 68.34% -0.01%
==========================================
Files 104 104
Lines 24101 24112 +11
Branches 4277 4280 +3
==========================================
+ Hits 16473 16480 +7
- Misses 6545 6547 +2
- Partials 1083 1085 +2
☔ View full report in Codecov by Sentry. |
plk
This looks good. Is it ready? |
Yes. |
Should I merge this? |
Sounds good to me! |
Unfittable parameters are parameters for which no derivatives are defined so that they cannot be fit.
fit_toas()
.TimingModel.designmatrix()
should fail with an informative error message upon encountering free unfittable parameters. Currently, it fails with an unclear error message.pintk
interface shouldn't list unfittable parameters. This will help unclutterpintk
.