-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local file system functionality to all tools #411
Merged
DavidSouther
merged 51 commits into
nand2tetris:release/fs-ui
from
netalondon:feat/local-fs
Sep 10, 2024
Merged
Changes from 44 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
6b249eb
Change hardware simulator to use local file system API
netalondon ad830c1
Handle chips with multiple test files
netalondon 19caa16
Allow dash in comapre file names
netalondon 30c87ab
Use local storage file system as fallback
netalondon 7dcad41
Always use file picker component
netalondon 8144f84
Fix test script dropdown
netalondon 48a03ce
Only load compare files using compare-to
netalondon 4781296
Add warning when can't find matching test file
netalondon fd48b0c
Track fs upgrade in assembler
netalondon 3a2c88d
Save seembler result on disk
netalondon 1166a4a
Add compare-to inst to cpu and vm tests
netalondon 72dddc9
Implement loading custom chips
netalondon 087db53
Fix ROM32K load inst in computer tests
netalondon addc194
Return chip selection dropdowns
netalondon 6d6893b
Fix change local fs
netalondon 9389f52
Cleanup old code
netalondon d83e9aa
Fix build errors
netalondon 3c6235c
Fix tests and test scripts
netalondon 5cb1a3e
CR
netalondon 507839b
CR
netalondon 5845000
Implement test script load command
netalondon 2e2b444
Fix compilation error when loading single vm file
netalondon d2e273f
Fix bug in vm file loading
netalondon 9cf4b42
Add async behavior to test script load command
netalondon 0c63bdf
Add error message when loaded file is missing
netalondon abda515
Fix build and CI errors
netalondon 2342739
CR
netalondon aaf2130
Remove console.logs
netalondon dcbc08e
Fix test
netalondon 0aa7faf
Move Action<T> change to another PR
netalondon 5e7dae9
Revert test panel ui changes
netalondon ed465be
Add newline in package.json
netalondon 29b7da4
Remove commented out code
netalondon fe7a17c
Fix build errors
netalondon 44fbe07
Reinstate reverted Action<string> cahnges
netalondon 4e5963b
Add missing import
netalondon b346fed
Fix bug where switching chips while builtin will override new file co…
netalondon eb98d99
Merge remote-tracking branch 'upstream/main' into feat/local-fs
netalondon d9cfd3a
Require a load command in test scripts
netalondon 906c6b0
Add file not found error message for load command
netalondon dfdfbea
Force CPU emulator test to either have load inst or a file already lo…
netalondon 647ac42
Merge remote-tracking branch 'upstream/main' into feat/local-fs
netalondon 057697c
Fix tests
netalondon 4683e18
Override pull in OutSubBus
netalondon 1552838
Add option to download project files from the IDE
netalondon a156e83
CR
netalondon c9d5b1f
Specify return type
netalondon d7b5b6f
Merge remote-tracking branch 'upstream/main' into feat/local-fs
netalondon 1abfe6f
Fix build error
netalondon d3cc013
Fix files not loaded on initial entrance in firefox
netalondon 346b057
Merge branch 'release/fs-ui' into feat/local-fs
DavidSouther File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) Remove