Add local file system functionality to all tools #411

netalondon · 2024-07-23T10:53:05Z

Closes #352

DavidSouther

I have reviewed the projects part and most of the stores, but I'm getting bogged down in the UI. Can you break this into two PRs - one that updates the project layout and structure, and a second that does the file system user interface?

package.json

simulator/src/test/chiptst.ts

simulator/src/test/tst.ts

simulator/src/test/vmtst.ts

extension/views/hdl/src/index.tsx

web/src/shell/test_panel.tsx

components/src/stores/chip.store.ts

DavidSouther

Again, I was able to review changes in projects/ and most of simulator/ and components, but please pull out (at least) web/ and related changes to a separate PR.

Looks like there's maybe four changes in here?

setStatus to Action
Project test structure
2b. Project files with updated load instructions
Web shell to create files

package.json

simulator/src/loader.ts

simulator/src/test/chiptst.ts

simulator/src/test/cputst.ts

simulator/src/test/vmtst.ts

web/src/pages/asm.tsx

netalondon · 2024-07-31T06:21:57Z

Again, I was able to review changes in projects/ and most of simulator/ and components, but please pull out (at least) web/ and related changes to a separate PR.

Looks like there's maybe four changes in here?

setStatus to Action

Project test structure
2b. Project files with updated load instructions

Web shell to create files

Sorry I missed your last comment about this. Will do.

…ntent

…aded

DavidSouther · 2024-08-08T12:05:43Z

components/src/stores/asm.store.ts

+      console.log(path);
+      console.log(await fs.scandir("/"));


(nit) Remove

components/src/stores/base.context.ts

components/src/stores/vm.store.ts

simulator/src/chip/builder.ts

DavidSouther · 2024-08-08T12:17:55Z

simulator/src/test/cputst.ts

    this.cpu = new CPU({ ROM: rom });
    this.reset();
  }

+  override async step() {
+    if (!this.hasLoad && !this.fileLoaded) {


(opt) De Morgan's for readability?

if (!(this.hasLoaded || this.fileLoaded))

* Add local file system functionality to all tools (#411) * Change hardware simulator to use local file system API * Handle chips with multiple test files * Allow dash in compare file names * Use local storage file system as fallback * Always use file picker component * Fix test script dropdown * Only load compare files using compare-to * Add warning when can't find matching test file * Track fs upgrade in assembler * Save assembler result on disk * Add compare-to inst to cpu and vm tests * Implement loading custom chips * Fix ROM32K load inst in computer tests * Return chip selection dropdowns * Implement test script load command * Fix compilation error when loading single vm file * Fix bug in vm file loading * Add async behavior to test script load command * Add error message when loaded file is missing * Fix bug where switching chips while builtin will override new file content * Require a load command in test scripts * Add file not found error message for load command * Force CPU emulator test to either have load inst or a file already loaded * Override pull in OutSubBus * Add option to download project files from the IDE * Specify return type * Fix files not loaded on initial entrance in firefox * Run tests on release/** branches * Request permission to local FS when needed (#456) * Detect hdl project folders instead of hardcoding them * Move dialog.tsx to components * Prompt user to grant permission when needed * Fix initialization for local storage fs * Add back HDL download button * Improve header layout for hardware simulator * Fix tooltip placement in chip Open button * Correctly await resetFiles in loader * Rework filesystem version IDs * Improve format and structure of version error handling. * Rework app async initialization, ensuring the file system is prepared before loading any pages. Co-authored-by: Neta London <[email protected]> Co-authored-by: David Souther <[email protected]>

DavidSouther requested changes Jul 24, 2024

View reviewed changes

DavidSouther requested changes Jul 30, 2024

View reviewed changes

netalondon force-pushed the feat/local-fs branch 5 times, most recently from fd76718 to 7220a12 Compare July 31, 2024 11:06

netalondon mentioned this pull request Jul 31, 2024

Local FS UI #419

Merged

netalondon added 21 commits July 31, 2024 15:13

Change hardware simulator to use local file system API

6b249eb

Handle chips with multiple test files

ad830c1

Allow dash in comapre file names

19caa16

Use local storage file system as fallback

30c87ab

Always use file picker component

7dcad41

Fix test script dropdown

8144f84

Only load compare files using compare-to

48a03ce

Add warning when can't find matching test file

4781296

Track fs upgrade in assembler

fd48b0c

Save seembler result on disk

3a2c88d

Add compare-to inst to cpu and vm tests

1166a4a

Implement loading custom chips

72dddc9

Fix ROM32K load inst in computer tests

087db53

Return chip selection dropdowns

addc194

Fix change local fs

6d6893b

Cleanup old code

9389f52

Fix build errors

d83e9aa

Fix tests and test scripts

3c6235c

CR

5cb1a3e

CR

507839b

Implement test script load command

5845000

netalondon added 2 commits July 31, 2024 15:17

Remove commented out code

29b7da4

Fix build errors

fe7a17c

netalondon force-pushed the feat/local-fs branch from 1d2dd5c to fe7a17c Compare July 31, 2024 12:18

netalondon added 11 commits August 1, 2024 11:46

Reinstate reverted Action<string> cahnges

44fbe07

Add missing import

4e5963b

Fix bug where switching chips while builtin will override new file co…

b346fed

…ntent

Merge remote-tracking branch 'upstream/main' into feat/local-fs

eb98d99

Require a load command in test scripts

d9cfd3a

Add file not found error message for load command

906c6b0

Force CPU emulator test to either have load inst or a file already lo…

dfdfbea

…aded

Merge remote-tracking branch 'upstream/main' into feat/local-fs

647ac42

Fix tests

057697c

Override pull in OutSubBus

4683e18

Add option to download project files from the IDE

1552838

maueroats mentioned this pull request Sep 2, 2024

[feature]: enable uploading of user-written test scripts #442

Open

2 tasks

DavidSouther reviewed Sep 3, 2024

View reviewed changes

netalondon added 4 commits September 8, 2024 08:52

CR

a156e83

Specify return type

c9d5b1f

Merge remote-tracking branch 'upstream/main' into feat/local-fs

d7b5b6f

Fix build error

1abfe6f

netalondon mentioned this pull request Sep 8, 2024

[bug]: Jack compiler tooltip is not visible in firefox #445

Open

2 tasks

netalondon marked this pull request as ready for review September 8, 2024 06:41

Fix files not loaded on initial entrance in firefox

d3cc013

netalondon force-pushed the feat/local-fs branch from c6fbf09 to d3cc013 Compare September 8, 2024 06:50

netalondon requested a review from DavidSouther September 8, 2024 06:57

DavidSouther changed the base branch from main to release/fs-ui September 10, 2024 22:19

DavidSouther approved these changes Sep 10, 2024

View reviewed changes

Merge branch 'release/fs-ui' into feat/local-fs

346b057

DavidSouther merged commit 6bfc5f1 into nand2tetris:release/fs-ui Sep 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add local file system functionality to all tools #411

Add local file system functionality to all tools #411

netalondon commented Jul 23, 2024 •

edited

Loading

DavidSouther left a comment

DavidSouther left a comment

netalondon commented Jul 31, 2024

DavidSouther Aug 8, 2024

DavidSouther Aug 8, 2024

Add local file system functionality to all tools #411

Add local file system functionality to all tools #411

Conversation

netalondon commented Jul 23, 2024 • edited Loading

DavidSouther left a comment

Choose a reason for hiding this comment

DavidSouther left a comment

Choose a reason for hiding this comment

netalondon commented Jul 31, 2024

DavidSouther Aug 8, 2024

Choose a reason for hiding this comment

DavidSouther Aug 8, 2024

Choose a reason for hiding this comment

netalondon commented Jul 23, 2024 •

edited

Loading