-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webpacker gem and install #380
base: master
Are you sure you want to change the base?
Conversation
62ff092
to
d19453f
Compare
This is working on staging. JS went from 393.6 KB to 166.9 KB |
Currently failing to build because of mime issue:
|
@garethrees Rails has been bumped and this branch has been rebased |
|
When bumping the node version it installs okay. diff --git a/script/provision-vagrant.sh b/script/provision-vagrant.sh
index ea59086..b22ee90 100644
--- a/script/provision-vagrant.sh
+++ b/script/provision-vagrant.sh
@@ -44,7 +44,7 @@ if [ ! -d "$HOME/.rbenv/versions/$RUBY_VERSION" ]; then
bundle config path "$HOME/.bundle"
fi
-export NODE_VERSION='8.10.0'
+export NODE_VERSION='14.16.0'
if [ ! -d "$HOME/.nvm/versions/node/v$NODE_VERSION" ]; then
echo 'Installing node and yarn'
nvm install $NODE_VERSION
The app boots with
I'm assuming 3 or 4 is the issue here. In the case of 4, well, it looks like we don't have a manifest. 3 could also be an issue. I note |
Futher testing for https://github.com/mysociety/sysadmin/issues/1407