Make build work with jdk 10 and use autodetection of surefire provider

[h3adache]

This allows proper detection of junit (so we don't skip junit 4 tests for example) and allows the project to build correctly using jdk 10

[h3adache]

Tested in mybatis-3/migrations/spring-boot-starter only.
If the configs for provider was added for some other project, I can look into it.

[harawata]

Thank you @h3adache !
I would wait for @hazendaz 's review, but I myself don't see any problem.

[hazendaz]

Only question, does eclipse still get confused? I know I had to make sure vintage was added on other projects so both 4 and 5 ran but that might be better now on recent surefire. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Iwao AVE! <[email protected]> Sent: Saturday, August 18, 2018 1:06:34 PM To: mybatis/parent Cc: Jeremy Landis; Mention Subject: Re: [mybatis/parent] Make build work with jdk 10 and use autodetection of surefire provider (#107) Thank you @h3adache<https://github.com/h3adache> ! I would wait for @hazendaz<https://github.com/hazendaz> 's review, but I myself don't see any problem. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#107 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho7GrjeVjxZUjcL_BAGBeRsJpIaTuks5uSEmagaJpZM4WCWBU>.

[hazendaz]

I should also note I had to have the others there for surefire as well. I just hasn't tried again without on recent surefire upgrades. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Jeremy Landis <[email protected]> Sent: Saturday, August 18, 2018 3:08:51 PM To: mybatis/parent; mybatis/parent Cc: Mention Subject: Re: [mybatis/parent] Make build work with jdk 10 and use autodetection of surefire provider (#107) Only question, does eclipse still get confused? I know I had to make sure vintage was added on other projects so both 4 and 5 ran but that might be better now on recent surefire. Get Outlook for Android<https://aka.ms/ghei36>

________________________________ From: Iwao AVE! <[email protected]> Sent: Saturday, August 18, 2018 1:06:34 PM To: mybatis/parent Cc: Jeremy Landis; Mention Subject: Re: [mybatis/parent] Make build work with jdk 10 and use autodetection of surefire provider (#107) Thank you @h3adache<https://github.com/h3adache> ! I would wait for @hazendaz<https://github.com/hazendaz> 's review, but I myself don't see any problem. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#107 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho7GrjeVjxZUjcL_BAGBeRsJpIaTuks5uSEmagaJpZM4WCWBU>.

[h3adache]

I'm not sure @hazendaz I don't use Eclipse. It works fine in Intellij and on the cmd line so I'm not sure why it wouldn't work in Eclipse.
These are all related to the surefire plugin, so I'm not sure what your 2nd comment meant.

[harawata]

According to this SO answer, surefire 2.22.0 does not require those plugin dependencies anymore.
https://stackoverflow.com/a/47158584/1261766

This new setup seems to be working fine with Eclipse 4.8.0 (JUnit picks up 1470 tests (11 skipped, 0 failure)).
There are a few issues with third party libraries when using JDK 10, though.

• CGLIB issue
• Embedded Postgresql issue (tests only)

[hazendaz]

Great! Thanks for the research and confirmations. I'm all good with this. Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Iwao AVE! <[email protected]> Sent: Saturday, August 18, 2018 9:09:13 PM To: mybatis/parent Cc: Jeremy Landis; Mention Subject: Re: [mybatis/parent] Make build work with jdk 10 and use autodetection of surefire provider (#107) According to this SO answer, surefire 2.22.0 does not require those plugin dependencies anymore. https://stackoverflow.com/a/47158584/1261766 This new setup seems to be working fine with Eclipse 4.8.0 (JUnit picks up 1470 tests (11 skipped, 0 failure)). There are a few issues with third party libraries when using JDK 10, though. * CGLIB issue<cglib/cglib#106> * Embedded Postgresql issue<yandex-qatools/postgresql-embedded#132> (tests only) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#107 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho8O87UUg_-t6R8VZeb7SxqHOp4duks5uSLq5gaJpZM4WCWBU>.