Add junit-vintage-engine on maven-surefire-plugin for supporting JUnit 4 #105
Conversation
|
Sounds good. Otherwise all tests on junit 4 get skipped.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Kazuki Shimizu <[email protected]>
Sent: Saturday, April 28, 2018 3:50:05 AM
To: mybatis/parent
Cc: Subscribed
Subject: [mybatis/parent] Add junit-vintage-engine on maven-surefire-plugin for supporting JUnit 4 (#105)
I will propose to add the junit-vintage-engine on maven-surefire-plugin 's dependency because many MyBatis modules depends on JUnit 4 yet.
It need to perform test case class created by JUnit 4 on JUnit platform.
________________________________
You can view, comment on, or merge this pull request online at:
#105
Commit Summary
* Add junit-vintage-engine on maven-surefire-plugin for supporting JUnit 4
File Changes
* M pom.xml<https://github.com/mybatis/parent/pull/105/files#diff-0> (5)
Patch Links:
* https://github.com/mybatis/parent/pull/105.patch
* https://github.com/mybatis/parent/pull/105.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#105>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho8JavH2Cecd5s_HWjvLRnHoTZatBks5ttB8tgaJpZM4TrS9F>.
|
|
@kazuki43zoo question on this before we merge. I've been adding vintage engine to projects that are not yet on junit 5 replacing the old junit 4 which just brings that in anyways. So, having said that, what real benefit do we get by adding it directly here? The underlying usage will still need junit anyways and I see no harm in upgrading those to vintage as it just works and we are on java 8. Am I missing something? I'm questioning this a big more as it is a differnent process than I've been using to adddress the same issue and just wondering how this saves me any work. |
|
I should note, I'm still ok with this as I assume it means we don't have to upgrade any underlying projects to vintage and can leave as-is which is a good thing for super poms that are used by dozens of unrelated projects. I'm just more trying to understand the intent here as it might help me change my ways as well on other projects :) |
|
Hi @hazendaz , I've upgraded to 31-SNAPSHOT on WDTY? |
|
Thanks. You have confirmed what this had me thinking. I'm good with adding it here. I think it's a good approach that prevents others from unexpected behaviour changed. Notes on read me would also be nice but this certainly will catch all and save others time. Based on this I'm going to do the same elsewhere on other projects. Great smart move here. Thanks.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Kazuki Shimizu <[email protected]>
Sent: Sunday, April 29, 2018 12:57:09 AM
To: mybatis/parent
Cc: Jeremy Landis; Mention
Subject: Re: [mybatis/parent] Add junit-vintage-engine on maven-surefire-plugin for supporting JUnit 4 (#105)
Hi @hazendaz<https://github.com/hazendaz> ,
I've upgraded to 31-SNAPSHOT on mybatis-spring-boot 2.0.0-SNAPSHOT. All test cases didn't executed because it was created using the JUnit 4.
I think that adding vintage-engine by default can reduce a same issue on child modules. And I think that useful to support multiple engine(jupiter-engine and vintege-engine) on the maven-surefire-plugin. For example, many IDEs supports multiple xUnit engine by default. I think this topic same with it on essentially.
Of course, I understand that this issue can be solved by adding the vintage-engine to the maven-surefire-plugin in the child module. If not add it in super pom, I think that better to announce about this topic (default behavior of maven-surefire-plugin) in README or Wiki Page etc...
WDTY?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#105 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA7ho5-4guKPHq4ReV30pkkssxgFg6wYks5ttUglgaJpZM4TrS9F>.
|
|
@kazuki43zoo with the PR just merged with surefire 2.22.0, I don't think we will need this one any longer. Can you take a quick look at #107 and confirm? |
|
closing as confirmed that we no longer need to set junit inside surefire. |
I will propose to add the
junit-vintage-engineonmaven-surefire-plugin's dependency because many MyBatis modules depends on JUnit 4 yet.It need to perform test case class created by JUnit 4 on JUnit platform.