Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: suppress some ad events when outside of an ad break #102

Merged
merged 12 commits into from
Nov 21, 2024
Merged

fix: suppress some ad events when outside of an ad break #102

merged 12 commits into from
Nov 21, 2024

Commits on Nov 20, 2024

  1. fix: suppress adplaying when outside of an ad break

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cb9496e View commit details
    Browse the repository at this point in the history

  2. filter out additional events

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5ee699f View commit details
    Browse the repository at this point in the history

  3. fix import

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    99e819b View commit details
    Browse the repository at this point in the history

  4. add test

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    eda3532 View commit details
    Browse the repository at this point in the history

  5. more tests

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2f3b5f9 View commit details
    Browse the repository at this point in the history

  6. whoops

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    be3a1e0 View commit details
    Browse the repository at this point in the history

  7. test: empty collected dispatched events across ad platying state tran… 

    …sitions

also check for adplay and adplaying filtering
after ads have finished playing
    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5a05ac5 View commit details
    Browse the repository at this point in the history

  8. fix logic

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9c0298c View commit details
    Browse the repository at this point in the history

  9. test: a few more tests and improve test failure messages

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6325f34 View commit details
    Browse the repository at this point in the history

  10. maybe this

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c525b07 View commit details
    Browse the repository at this point in the history

  11. remove unnecessary import

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    c1899b3 View commit details
    Browse the repository at this point in the history

  12. remove nested if

    @andrewjl-mux
    andrewjl-mux committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    760e7d6 View commit details
    Browse the repository at this point in the history