fix: suppress some ad events when outside of an ad break #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjl-mux
changed the title
…sitions also check for adplay and adplaying filtering after ads have finished playing
cjpillsbury
requested changes
Nov 20, 2024
library/src/main/java/com/mux/stats/sdk/muxstats/MuxStatsSdkMedia3.kt
Outdated
Show resolved
Hide resolved
| eventBus.dispatch(event) | ||
| if (muxPlayerState == MuxPlayerState.PLAYING_ADS) { | ||
| eventBus.dispatch(event) | ||
| } else { |
There was a problem hiding this comment.
nitpick: else if vs. else + (nested) if?
| adCollector.dispatch(AdPlayEvent(null)) | ||
| adCollector.dispatch(AdPlayingEvent(null)) | ||
|
|
||
| Assert.assertTrue( |
There was a problem hiding this comment.
suggestion(non-blocking): use a loop + all expected filtered out ad events for your assertions. Alternatively, just write individual tests for every ad event like you did for the "allowed" ones, below (which allows test to better isolate an issue)
andrewjl-mux
deleted the
ajlb/fix/suppress-adplaying-outside-of-ad-breaks
branch
Merged
daytime-em
added a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out events we do not expect to receive outside of an ad break.