Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scam detection #1079

Merged
merged 5 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions schema.gql
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,7 @@ type Mutation {
stopNftCreate(input: StopNftCreateArgs!): TransactionNode!
transferNft(input: TransferNftArgs!): TransactionNode!
transferNftCreateRole(input: TransferNftCreateRoleArgs!): TransactionNode!
trigerScamUpdate(input: ScamUpdateInput!): Boolean!
updateCollectionRarities(collectionTicker: String!): Boolean!
updateCollectionTraits(collectionTicker: String!): Boolean!
updateMarketplace(input: UpdateMarketplaceArgs!): Boolean!
Expand Down Expand Up @@ -1342,6 +1343,16 @@ enum ScamInfoTypeEnum {
scam
}

enum ScamInputEnum {
allow
deny
}

input ScamUpdateInput {
collectionIdentifier: String!
type: ScamInputEnum!
}

input SearchFilter {
searchTerm: String!
}
Expand Down
4 changes: 3 additions & 1 deletion src/modules/admins/admin-operations.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ import { NftTraitsModule } from '../nft-traits/nft-traits.module';
import { MarketplacesModuleGraph } from '../marketplaces/marketplaces.module';
import { AuthModule } from '../auth/auth.module';
import { ReportsModuleGraph } from '../reports/reports.module';
import { ScamUpdatePublisherModule } from '../rabbitmq/elastic-updates/scam-trigger/scam-update-publiser.module';

@Module({
imports: [
CommonModule,
CacheEventsPublisherModule,
ScamUpdatePublisherModule,
MxCommunicationModule,
NftRarityModuleGraph,
NftTraitsModule,
Expand All @@ -36,4 +38,4 @@ import { ReportsModuleGraph } from '../reports/reports.module';
],
exports: [FlagNftService],
})
export class AdminOperationsModuleGraph {}
export class AdminOperationsModuleGraph { }
12 changes: 11 additions & 1 deletion src/modules/admins/admin-operations.resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import { ReportsService } from '../reports/reports.service';
import { ClearReportCollectionInput, ClearReportInput } from './models/clear-report.input';
import { MarketplaceReindexDataArgs } from '../marketplaces/models/MarketplaceReindexDataArgs';
import { GraphQLError } from 'graphql';
import { ScamUpdatePublisherService } from '../rabbitmq/elastic-updates/scam-trigger/scam-update-publiser.service';
import { ScamUpdateInput } from './models/scam-update.input';

@Resolver(() => Boolean)
export class AdminOperationsResolver {
Expand All @@ -27,9 +29,10 @@ export class AdminOperationsResolver {
private readonly nftRarityService: NftRarityService,
private readonly nftTraitService: NftTraitsService,
private readonly cacheEventsPublisherService: CacheEventsPublisherService,
private readonly scamUpdatePublisherService: ScamUpdatePublisherService,
private readonly marketplaceEventsIndexingService: MarketplaceEventsIndexingService,
private readonly marketplacesReindexService: MarketplacesReindexService,
) {}
) { }

@Mutation(() => Boolean)
@UseGuards(JwtOrNativeAuthGuard, GqlAdminAuthGuard)
Expand Down Expand Up @@ -157,4 +160,11 @@ export class AdminOperationsResolver {
});
return true;
}

@Mutation(() => Boolean)
@UseGuards(JwtOrNativeAuthGuard, GqlAdminAuthGuard)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

async trigerScamUpdate(@Args('input', { type: () => ScamUpdateInput }) input: ScamUpdateInput): Promise<boolean> {
this.scamUpdatePublisherService.publish({ collectionIdentifier: input.collectionIdentifier, type: input.type });
return true;
}
}
24 changes: 24 additions & 0 deletions src/modules/admins/models/scam-update.input.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { InputType, Field, registerEnumType } from '@nestjs/graphql';
import { Matches } from 'class-validator';
import { COLLECTION_IDENTIFIER_ERROR, COLLECTION_IDENTIFIER_RGX } from 'src/utils/constants';

@InputType()
export class ScamUpdateInput {
@Matches(RegExp(COLLECTION_IDENTIFIER_RGX), {
message: COLLECTION_IDENTIFIER_ERROR,
})
@Field(() => String)
collectionIdentifier: string;

@Field(() => ScamInputEnum)
type: ScamInputEnum;
}

export enum ScamInputEnum {
deny = 'deny',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use PascalCase for enums (if applicable)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to keep them like this here because of mongo

allow = 'allow'
}

registerEnumType(ScamInputEnum, {
name: 'ScamInputEnum',
});
3 changes: 1 addition & 2 deletions src/modules/rabbitmq/blockchain-events/nft-events.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ import { PluginModule } from 'src/plugins/plugin.module';
import { AnalyticsEventsService } from './analytics-events.service';
import { AnalyticsModule } from 'src/modules/analytics/analytics.module';
import { MintersModuleGraph } from 'src/modules/minters/minters.module';
import { DisabledMarketplaceEventsService } from './disable-marketplace/disable-marketplace-events.service';
import { DisabledMarketplaceEventsModule } from './disable-marketplace/disable-marketplace-events.module';
@Module({
imports: [
Expand Down Expand Up @@ -102,4 +101,4 @@ import { DisabledMarketplaceEventsModule } from './disable-marketplace/disable-m
],
exports: [NftEventsService, NftEventsConsumer],
})
export class NftEventsModule {}
export class NftEventsModule { }
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@ import { CampaignsCachingService } from 'src/modules/campaigns/campaigns-caching
import { MarketplaceRedisHandler } from 'src/modules/marketplaces/loaders/marketplace.redis-handler';
import { AssetsSupplyRedisHandler } from 'src/modules/assets/loaders/assets-supply.redis-handler';
import { PubSubListenerModule } from 'src/pubsub/pub.sub.listener.module';
import { ScamUpdatePublisherModule } from '../elastic-updates/scam-trigger/scam-update-publiser.module';

@Module({
imports: [
PubSubListenerModule,
CommonModule,
CacheInvalidationEventsModule,
ScamUpdatePublisherModule,
CacheAdminEventsModule,
CommonRabbitModule.register(() => {
return {
Expand All @@ -49,4 +51,4 @@ import { PubSubListenerModule } from 'src/pubsub/pub.sub.listener.module';
],
exports: [],
})
export class CacheEventsModule {}
export class CacheEventsModule { }
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ import { CacheEventsPublisherService, NftLikePublisherService } from './change-e
providers: [CacheEventsPublisherService, NftLikePublisherService],
exports: [CacheEventsPublisherService, NftLikePublisherService],
})
export class CacheEventsPublisherModule {}
export class CacheEventsPublisherModule { }
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { ScamInputEnum } from "src/modules/admins/models/scam-update.input";

export class MarkScamCollectionEvent {
collectionIdentifier: string;
type: ScamInputEnum
constructor(init?: Partial<MarkScamCollectionEvent>) {
Object.assign(this, init);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { forwardRef, Global, Module } from '@nestjs/common';
import { rabbitExchanges } from '../../rabbit-config';
import { CommonRabbitModule } from '../../cache-invalidation/common-rabbitmq.module';
import { ScamUpdateEventsConsumer } from './scam-update-events.consumer';
import { ScamModule } from 'src/modules/scam/scam.module';

@Global()
@Module({
imports: [
CommonRabbitModule.register(() => {
return {
exchange: rabbitExchanges.SCAM_UPDATE,
uri: process.env.COMMON_RABBITMQ_URL,
};
}),
forwardRef(() => ScamModule)
],
providers: [ScamUpdateEventsConsumer],
exports: [ScamUpdateEventsConsumer],
})
export class ScamUpdateConsumerModule { }
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { Injectable } from '@nestjs/common';
import { rabbitExchanges, rabbitQueues } from '../../rabbit-config';
import { MarkScamCollectionEvent } from './markScamCollection.event';
import { CompetingRabbitConsumer } from '../../rabbitmq.consumers';
import { CollectionScamService } from 'src/modules/scam/collection-scam.service';
import { ScamInputEnum } from 'src/modules/admins/models/scam-update.input';
@Injectable()
export class ScamUpdateEventsConsumer {
constructor(private readonly collectionScamService: CollectionScamService) { }

@CompetingRabbitConsumer({
connection: 'common',
queueName: rabbitQueues.SCAM_UPDATE,
exchange: rabbitExchanges.SCAM_UPDATE,
})
async consumeScamEvents(event: MarkScamCollectionEvent) {
if (event.type === ScamInputEnum.allow) {
await this.collectionScamService.manuallyClearCollectionScamInfo(event.collectionIdentifier)
} else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have also been "else if" for "deny", and throw error (unrecognized) on "else".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to let it like this because are only two possibilities and in the future if we add another one then update the condition 🙏

await this.collectionScamService.manuallySetCollectionScamInfo(event.collectionIdentifier)
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { Global, Module } from '@nestjs/common';
import { rabbitExchanges } from '../../rabbit-config';
import { CommonRabbitModule } from '../../cache-invalidation/common-rabbitmq.module';
import { ScamUpdatePublisherService } from './scam-update-publiser.service';

@Global()
@Module({
imports: [
CommonRabbitModule.register(() => {
return {
exchange: rabbitExchanges.SCAM_UPDATE,
uri: process.env.COMMON_RABBITMQ_URL,
};
}),
],
providers: [ScamUpdatePublisherService],
exports: [ScamUpdatePublisherService],
})
export class ScamUpdatePublisherModule { }
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { Injectable } from '@nestjs/common';
import { rabbitExchanges } from '../../rabbit-config';
import { RabbitPublisherService } from '../../rabbit.publisher';
import { MarkScamCollectionEvent } from './markScamCollection.event';


@Injectable()
export class ScamUpdatePublisherService {
constructor(private readonly rabbitPublisherService: RabbitPublisherService) { }

async publish(payload: MarkScamCollectionEvent) {
await this.rabbitPublisherService.publish(rabbitExchanges.SCAM_UPDATE, payload);
}
}
2 changes: 2 additions & 0 deletions src/modules/rabbitmq/rabbit-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ export interface RabbitModuleConfig {
export const rabbitExchanges = {
CACHE_INVALIDATION: 'nft-cache-invalidation',
NFT_LIKE: 'x_portal_gamification_nft_likes_exchange',
SCAM_UPDATE: 'nft-scam-update',
};

export const rabbitQueues = {
CACHE_INVALIDATION: 'nft-cache-invalidation',
SCAM_UPDATE: 'nft-scam-update',
};
4 changes: 2 additions & 2 deletions src/modules/scam/scam.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ import { NftScamService } from './nft-scam.service';
CollectionScamResolver,
AssetByIdentifierService,
],
exports: [NftScamService, NftScamElasticService, AssetByIdentifierService],
exports: [NftScamService, NftScamElasticService, AssetByIdentifierService, CollectionScamService],
})
export class ScamModule {}
export class ScamModule { }
6 changes: 3 additions & 3 deletions src/private.app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ import { MetricsController } from './modules/metrics/metrics.controller';
import { NftRarityModuleGraph } from './modules/nft-rarity/nft-rarity.module';
import { ScamModule } from './modules/scam/scam.module';
import { NftTraitsModule } from './modules/nft-traits/nft-traits.module';
import { CacheEventsPublisherModule } from './modules/rabbitmq/cache-invalidation/cache-invalidation-publisher/change-events-publisher.module';
import * as ormconfig from './ormconfig';
import { ScamUpdateConsumerModule } from './modules/rabbitmq/elastic-updates/scam-trigger/scam-update-consumer.module';

@Module({
imports: [
TypeOrmModule.forRoot({ ...ormconfig, keepConnectionAlive: true }),
CommonModule,
AdminOperationsModuleGraph,
NftRarityModuleGraph,
CacheEventsPublisherModule,
ScamUpdateConsumerModule,
ScamModule,
NftTraitsModule,
MarketplacesModuleGraph,
Expand All @@ -31,4 +31,4 @@ import * as ormconfig from './ormconfig';
controllers: [MetricsController, ReindexController, CachingController],
exports: [NsfwUpdaterService, RarityUpdaterService],
})
export class PrivateAppModule {}
export class PrivateAppModule { }
Loading