Update scam detection #1079
Merged
Update scam detection #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
danielailie
commented
Sep 19, 2024
•
danielailie
commented
- add endpoint for admin to trigger scam update for certain collection
- add rabbit queue where an event will be posted after the endpoint gets call
- add consumer that will mark or clear the scam based on the input
andreibancioiu
approved these changes
Sep 25, 2024
| @@ -157,4 +160,11 @@ export class AdminOperationsResolver { | |||
| }); | |||
| return true; | |||
| } | |||
|
|
|||
| @Mutation(() => Boolean) | |||
| @UseGuards(JwtOrNativeAuthGuard, GqlAdminAuthGuard) | |||
| } | ||
|
|
||
| export enum ScamInputEnum { | ||
| deny = 'deny', |
There was a problem hiding this comment.
Maybe use PascalCase for enums (if applicable)?
There was a problem hiding this comment.
I need to keep them like this here because of mongo
| async consumeScamEvents(event: MarkScamCollectionEvent) { | ||
| if (event.type === ScamInputEnum.allow) { | ||
| await this.collectionScamService.manuallyClearCollectionScamInfo(event.collectionIdentifier) | ||
| } else { |
There was a problem hiding this comment.
Could have also been "else if" for "deny", and throw error (unrecognized) on "else".
There was a problem hiding this comment.
I would like to let it like this because are only two possibilities and in the future if we add another one then update the condition 🙏
cfaur09
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.