Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember v5 deprecations #36

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Nov 5, 2024

This resolves the relevant deprecations introduced in Ember v5.

@Windvis
Copy link
Contributor Author

Windvis commented Nov 5, 2024

if (this.selection === undefined) this.set('selection', []);

this.selection is either an arg or an internal array, but we're using EmberArray methods (so prototype extensions must be enabled). I don't think we can simply replace them with vanilla array equivalents since we need to mutate the array and also trigger a change.

So I think our only option is to create an ember array internally and assume the argument is one as well. Consuming apps would then have to enable the prototype extensions or create an ember array explicitly before passing it in (which is already the case at the moment).

@Windvis Windvis force-pushed the ember-v5-deprecations branch from bbaa19e to 2f339ba Compare November 12, 2024 12:44
The classic file structure for component has been deprecated.

More info: https://deprecations.emberjs.com/v5.x/#toc_component-template-resolving
@Windvis Windvis force-pushed the ember-v5-deprecations branch from 2f339ba to 03204cb Compare November 12, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant