Remove action from the data-table-content-body component

mu-semtech · Nov 12, 2024 · bbaa19e · bbaa19e
1 parent c1bc7be
commit bbaa19e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/addon/components/data-table-content-body.js b/addon/components/data-table-content-body.js
@@ -1,5 +1,5 @@
 import { set } from '@ember/object';
-import { computed } from '@ember/object';
+import { action, computed } from '@ember/object';
 import Component from '@ember/component';
 import layout from '../templates/components/data-table-content-body';
 
@@ -32,16 +32,14 @@ export default Component.extend({
       });
     }
   ),
-  actions: {
-    updateSelection(selectedWrapper, event) {
-      set(selectedWrapper, 'isSelected', event.target.checked);
-      this.wrappedItems.forEach((wrapper) => {
-        if (wrapper.isSelected) {
-          this.get('data-table').addItemToSelection(wrapper.item);
-        } else {
-          this.get('data-table').removeItemFromSelection(wrapper.item);
-        }
-      });
-    },
-  },
+  updateSelection: action(function (selectedWrapper, event) {
+    set(selectedWrapper, 'isSelected', event.target.checked);
+    this.wrappedItems.forEach((wrapper) => {
+      if (wrapper.isSelected) {
+        this.get('data-table').addItemToSelection(wrapper.item);
+      } else {
+        this.get('data-table').removeItemFromSelection(wrapper.item);
+      }
+    });
+  }),
 });
diff --git a/addon/templates/components/data-table-content-body.hbs b/addon/templates/components/data-table-content-body.hbs
@@ -6,7 +6,8 @@
       <tr role="button" class="{{if (includes wrapper.item this.data-table.selection) "selected"}} {{if this.onClickRow "clickable"}}" {{on "click" (fn (optional this.onClickRow) wrapper.item)}}>
         {{#if this.enableSelection}}
           <td class="center">
-            <Input @type="checkbox" @checked={{wrapper.isSelected}} {{on "click" (action "updateSelection" wrapper)}} />
+            hello
+            <Input @type="checkbox" @checked={{wrapper.isSelected}} {{on "click" (fn this.updateSelection wrapper)}} />
           </td>
         {{/if}}
         {{#if this.enableLineNumbers}}