feat: Migration from 16.x to 17.x (latest version) #185
Conversation
markvdouw
requested review from
jasonmgeorge,
BrandonStalnaker and
mmustafa-tse
markvdouw
force-pushed
the
feat/migration_16_17
branch
from
8474d2d to
4e8bd7a
Compare
markvdouw
force-pushed
the
feat/migration_16_17
branch
from
4e8bd7a to
b4e241a
Compare
| } | ||
| //The onChange fun within the AirshipChannelListener was removed. | ||
| //PushNotificationStatusListener reporting changes instead (ref. [#https://github.com/urbanairship/android-library/blob/17.0.0/documentation/migration/migration-guide-16-17.md]) | ||
| airship.pushManager.addNotificationStatusListener { callChannelIdListener() } |
There was a problem hiding this comment.
It looks like all this is doing is setting the Airship channel ID as an attribute on mParticle. The channel in practice never changes but we do have a path in the SDK that we could regenerate it. If thats the case the onCreate will get called again.
I think all you need to do is sync on onAirshipReady and sync on channel created.
| override fun onChannelCreated(s: String) { | ||
| callChannelIdListener() | ||
| override fun onChannelCreated(channelId: String) { | ||
|
|
There was a problem hiding this comment.
if the method isn't used anymore should we just remove it?
| @@ -206,7 +202,7 @@ class UrbanAirshipKit : KitIntegration(), KitIntegration.PushListener, KitIntegr | |||
| .apply() | |||
| } | |||
| if (identityType == configuration?.userIdField) { | |||
| UAirship.shared().namedUser.id = null | |||
| UAirship.shared().contact.reset() // Previously setting namedUser to null but now is immutable | |||
There was a problem hiding this comment.
This is basically the same thing as setting it null if the user is only managed through the SDK, but its possible that if the was set to a user server side this would now reset that association. I think it would be safer to only reset it if its not set through the SDK:
if (UAirship.shared().contact.namedUserId != null) {
UAirship.shared().contact.reset()
}
|
@rlepinski Is the change aligned with what you are recommending? |
| @@ -9,6 +9,7 @@ import com.urbanairship.AirshipConfigOptions | |||
| import com.urbanairship.Autopilot | |||
| import com.urbanairship.UAirship | |||
| import com.urbanairship.channel.AirshipChannelListener | |||
| import com.urbanairship.push.PushNotificationStatus | |||
There was a problem hiding this comment.
I don't think this is being used
|
@markvdouw Yep! |
Instructions
developmentSummary
Migration from 16.x to 17.x (latest version)
Reference: https://github.com/urbanairship/android-library/blob/17.0.0/documentation/migration/migration-guide-16-17.md
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)
Initial work for: https://mparticle-eng.atlassian.net/browse/SQDSDKS-5988