Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use 0 arguments in keyboard.Controller.__init__ #519

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Always use 0 arguments in keyboard.Controller.__init__ #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a93daf7
Always use 0 arguments in `keyboard.Controller.__init__`
sobolevn Nov 21, 2022
71b8d79
`mouse.Controller` has the same problem
sobolevn Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/pynput/keyboard/_uinput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@ class Controller(_base.Controller):
_KeyCode = KeyCode
_Key = Key

def __init__(self, *args, **kwargs):
super(Controller, self).__init__(*args, **kwargs)
def __init__(self):
super(Controller, self).__init__()
self._layout = LAYOUT
self._dev = evdev.UInput()

Expand Down
4 changes: 2 additions & 2 deletions lib/pynput/keyboard/_win32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,8 @@ class Controller(_base.Controller):
_KeyCode = KeyCode
_Key = Key

def __init__(self, *args, **kwargs):
super(Controller, self).__init__(*args, **kwargs)
def __init__(self):
super(Controller, self).__init__()

def _handle(self, key, is_press):
SendInput(
Expand Down
4 changes: 2 additions & 2 deletions lib/pynput/keyboard/_xorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ class Controller(NotifierMixin, _base.Controller):
#: The shift mask for :attr:`Key.shift`
SHIFT_MASK = Xlib.X.ShiftMask

def __init__(self, *args, **kwargs):
super(Controller, self).__init__(*args, **kwargs)
def __init__(self):
super(Controller, self).__init__()
self._display = Xlib.display.Display()
self._keyboard_mapping = None
self._borrows = {}
Expand Down
4 changes: 2 additions & 2 deletions lib/pynput/mouse/_darwin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ class Controller(_base.Controller):
#: The scroll speed
_SCROLL_SPEED = 10

def __init__(self, *args, **kwargs):
super(Controller, self).__init__(*args, **kwargs)
def __init__(self):
super(Controller, self).__init__()
self._click = None
self._drag_button = None

Expand Down
4 changes: 2 additions & 2 deletions lib/pynput/mouse/_win32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ class Controller(NotifierMixin, _base.Controller):
__GetCursorPos = windll.user32.GetCursorPos
__SetCursorPos = windll.user32.SetCursorPos

def __init__(self, *args, **kwargs):
super(Controller, self).__init__(*args, **kwargs)
def __init__(self):
super(Controller, self).__init__()

def _position_get(self):
point = wintypes.POINT()
Expand Down
4 changes: 2 additions & 2 deletions lib/pynput/mouse/_xorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@


class Controller(_base.Controller):
def __init__(self, *args, **kwargs):
super(Controller, self).__init__(*args, **kwargs)
def __init__(self):
super(Controller, self).__init__()
self._display = Xlib.display.Display()

def __del__(self):
Expand Down