Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use 0 arguments in keyboard.Controller.__init__ #519

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Always use 0 arguments in keyboard.Controller.__init__ #519

wants to merge 2 commits into from

Conversation

sobolevn
Copy link

No description provided.

@sobolevn
Copy link
Author

This is a problem for us in typeshed, see: python/typeshed#9235

This change is also backward compatible, becase super(_base.Controller, self).__init__() was always called. And no arguments were allowed in _base.Controller.__init__ anyway, so it should be all good.

@sobolevn sobolevn mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sobolevn