Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invariants in CI #706

Merged
merged 13 commits into from
Nov 25, 2024
Merged

Fix invariants in CI #706

merged 13 commits into from
Nov 25, 2024

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Nov 24, 2024

Working on top of #595.

This PR:

  • restores invariants in the CI
  • fixes a rounding direction issue when finding a bound for liquidate repaid shares
  • fixes using an incorrect market when finding a bound for liquidate repaid shares (see d4d5e56)
  • separates dynamic invariants from static invariants. Static meaning that it's all at the same block and price does not change (see the added function selectors in DynamicInvariantTest.sol)
  • removes weights of selectors. How often a function is expected to be called is not a good indicator of the contribution it could have in bugs and hacks

@QGarchery QGarchery self-assigned this Nov 24, 2024
@QGarchery QGarchery linked an issue Nov 24, 2024 that may be closed by this pull request
@QGarchery QGarchery marked this pull request as ready for review November 24, 2024 17:03
@QGarchery QGarchery requested review from MathisGD, Rubilmax, a team, adhusson, MerlinEgalite and Jean-Grimal and removed request for a team November 24, 2024 17:03
@MathisGD MathisGD merged commit abeb928 into main Nov 25, 2024
17 checks passed
@MathisGD MathisGD deleted the ci/fix-invariant branch November 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore invariants in CI
4 participants