fix invariants tests #595
Closed
fix invariants tests #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Rubilmax
commented
Nov 17, 2023
Rubilmax
commented
- Fixes Restore invariants in CI #588
Rubilmax
requested review from
QGarchery,
MerlinEgalite,
MathisGD and
Jean-Grimal
MathisGD
previously approved these changes
Nov 21, 2023
test(invariant): re-implement lost invariants
MathisGD
changed the title
MathisGD
reviewed
Mar 7, 2024
| _weightSelector(this.setPrice.selector, 5); | ||
| _weightSelector(this.mine.selector, 100); | ||
|
|
||
| super.setUp(); |
There was a problem hiding this comment.
I dont' get why this is put before the weightSelectors, some tests fail..
Rubilmax
commented
Mar 8, 2024
| invariant-runs: 0 | ||
| invariant-runs: 32 |
There was a problem hiding this comment.
The CI was running for 183m before failing, perhaps we should lower these
Jean-Grimal
approved these changes
Mar 8, 2024
Merged
|
Replaced by #706 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.