-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add connectionInfo to telemetry calls, and connectionId to events COMPASS-7968 #5977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
changed the title
Compass 7968 2
fix: add connectionInfo to telemetry COMPASS-7968
Jun 27, 2024
paula-stacho
changed the title
fix: add connectionInfo to telemetry COMPASS-7968
fix: add connectionInfo to telemetry calls, and connectionId to events COMPASS-7968
Jun 28, 2024
paula-stacho
force-pushed
the
COMPASS-7968-2
branch
from
June 28, 2024 13:13
78e7035
to
f1d487e
Compare
mcasimir
reviewed
Jun 28, 2024
paula-stacho
force-pushed
the
COMPASS-7968-2
branch
2 times, most recently
from
July 3, 2024 12:16
d3c2cf4
to
71118d2
Compare
himanshusinghs
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I left a few small suggestions and question.
packages/compass-aggregations/src/modules/pipeline-builder/pipeline-mode.ts
Outdated
Show resolved
Hide resolved
packages/compass-indexes/src/components/create-index-modal/create-index-modal.tsx
Show resolved
Hide resolved
packages/compass-indexes/src/components/search-indexes-modals/base-search-index-modal.tsx
Show resolved
Hide resolved
mcasimir
reviewed
Jul 8, 2024
paula-stacho
force-pushed
the
COMPASS-7968-2
branch
2 times, most recently
from
July 10, 2024 14:10
4ecb511
to
cef73cb
Compare
paula-stacho
force-pushed
the
COMPASS-7968-2
branch
from
July 11, 2024 08:16
cef73cb
to
95e0f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
strategy
compass/packages/compass/src/app/components/workspace.tsx
Lines 108 to 113 in cc3acaf
event plan
These are the events that I added connectionInfo to
Shell ${string}
These have the connectionInfo sometimes
And these are general scope
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes