fix(serverstats): use telemetry hook in component COMPASS-8056 #5988
Conversation
| const onShow = useCallback((newDataToShow: CurrentOpData) => { | ||
| setData(newDataToShow); | ||
| }, []); | ||
|
|
||
| const onHide = useCallback(() => { | ||
| setData(null); | ||
| }, []); |
There was a problem hiding this comment.
Small nit: because .listen method returns unsubscribe functions, you dont even need extra useCallbacks here, can just define those functions right in the listen methods, less code and runtime
There was a problem hiding this comment.
@Anemy @paula-stacho is this related with #5977, do we need to send a connection_id?
yes, done this in https://github.com/mongodb-js/compass/pull/5977/files#diff-2eac96a4c76cb2ac0fa28e8b3e11457b5e7f08871b257ad724ea32e427cb77cbR47-R51 and also noticed this |
COMPASS-8056
Looks like a bug that would be caught by typescript so I also updated the file to typescript. Happy to instead keep it js and make the one line change of using
trackinstead ofloggerfrom the component props.We should refactor all of this performance page, so I refrained from doing more than just js -> ts for now. I did remove the error display though as it wasn't ever used.