Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test matrix to include Python 3.9 to 3.12 #479

Merged
merged 15 commits into from
Nov 21, 2024

Conversation

caufieldjh
Copy link
Member

No description provided.

@caufieldjh caufieldjh linked an issue Nov 17, 2024 that may be closed by this pull request
@caufieldjh
Copy link
Member Author

@caufieldjh
Copy link
Member Author

Some dependency is trying to use scipy 1.13.1 but scipy is only compatible with Python 3.13 as of 1.14.1 - https://scipy.org/news/#scipy-1141-released

@caufieldjh
Copy link
Member Author

Hrm, poetry really wants to install numpy 2.0.0rc1 instead of 2.1, but the former won't work with Python 3.13.
scikit-learn may be the culprit.

@caufieldjh
Copy link
Member Author

This is strange - the builds other than Python 3.13 aren't even requiring scikit-learn as a dependency (they don't install it) but that's what 3.13 appears to be failing on, because it's trying to install scikit-learn and that wants numpy 2.0.0rc1, which doesn't exist.

This may instead be referring to sqlalchemy 2.0.0rc1 as sqlalchemy is an upstream dependency for packages like oaklib, but what is trying to install that specific version if that's the case?

@caufieldjh
Copy link
Member Author

OK, so numpy 2.0.0rc1 may have existed at some point, and some scikit-learn versions built against that when it was the most recent numpy 2 available (see scikit-learn/scikit-learn#29360).
So the real issue here is forcing numpy >=2. Will try a slightly different config here

@caufieldjh
Copy link
Member Author

Now it's an issue with tiktoken. Trying a more generous pin as there's a new version of that out as of last month

@caufieldjh
Copy link
Member Author

That's the dependencies handled but now tests are failing on 3.13, mostly because of ImportError: cannot import name 're' from 'typing', and that happens because linkml_runtime does it

@caufieldjh
Copy link
Member Author

Blocked by linkml/linkml#2420

@caufieldjh
Copy link
Member Author

Since 3.9 to 3.12 work, I will restrict the test matrix to those versions and support 3.13 once linkml allows.

@caufieldjh caufieldjh changed the title Expand test matrix to include Python 3.9 to 3.13 Expand test matrix to include Python 3.9 to 3.12 Nov 21, 2024
@caufieldjh caufieldjh marked this pull request as ready for review November 21, 2024 20:14
@caufieldjh caufieldjh merged commit d52583e into main Nov 21, 2024
4 checks passed
@caufieldjh caufieldjh deleted the 467-test-on-python-311-to-313 branch November 21, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test on Python 3.11 to 3.12
1 participant