initial stab & functionality of spine marks #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sithel
commented
Mar 10, 2024
There was a problem hiding this comment.
other than gobs of logs that need to be ripped out, it's not that bad
I'm not promising a test -- this is written on the weekend, damnit! -- but will look to see if anything is easy enough to add (and will def fix one I broke) -- also going to wait to hear some tester feedback
… only some folios & some bug fixes (#115) * now with a PDF Markup section + sewing marks on only some of the folios
|
Can you update the version number on this? Forgot to check on the other request for that, but they cover some of the same stuff anyway, lol |
|
version bump bumped |
|
Go ahead and merge this once that dev flag is switched, everything else looks good. |
|
turned off dev flag (good catch!) but need a ✅ before I can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinelines! ✨
Octopus | Little Cat Press on the main discord tested it out and gave it a 👍
I vetted the output PDF and those marks are in the center but fuck me- they don't print like it! Printed a funking chonker only to find out they were slightly off-center in output.... Still workable though and very helpful! Need to add an adjustment field to help with that, but that's for later UI/UX
I am still VERY cranky about being told I couldn't add a "full preview" checkbox to the page. Really... quite upset about that... but I left it off and added in
fullPreviewDevHacktocreateoutputfilesinbook.jsfirst half of thoughts/process written up here -- of course I dove back in today and found a number of issues/incorrect assumptions that I may or may not go back and document 😩